-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): migrate DropdownMenu component #7233
feat(UI): migrate DropdownMenu component #7233
Conversation
25aa77e
to
b521828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should expose this as Dropdown unless we know it can be used as a replacement for a select control (e.g. in Settings > Preferences), which I don't think it does. Let's find another name or talk about options for meeting both needs.
Converting to draft for now as more discussion required |
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
79b32d7
to
cac7317
Compare
Re-opened |
* feat(UI): migrate dropdown component Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com> * fix(Dropdown): better naming for component Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com> * fix(Dropdown): import issue Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com> * fix: revert name to DropDownMenu Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com> --------- Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
What does this PR do?
Migrating DropdownMenu component to ui library
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #6918
How to test this PR?