chore: move FormPage to its own component #7472
Conversation
|
the problem I have is that my PR is failing on CI :-( but on my side it's working so I'm still investigating |
| @@ -0,0 +1,82 @@ | |||
| <script lang="ts"> | |||
| import { CloseButton, LinearProgress, Link } from '@podman-desktop/ui-svelte'; | |||
There was a problem hiding this comment.
Maybe we should not import itself as a package ?
There was a problem hiding this comment.
what is strange is why it's only reproducing on the CI, I would hope that developers have the same failure
There was a problem hiding this comment.
maybe try to delete the export/dist folder, and you should be able to reproduce ?
There was a problem hiding this comment.
Or delete node_modules? i.e. you've already done a yarn install and have a local cache of what it will build here.
I just tried locally, and tests are passing too... but I think it may come from the import itself package |
remove tinro dependency in the UI component keep a tinro FormPage in renderer part that is just delegating the calls fixes containers#6920 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
* chore: move FormPage to its own component remove tinro dependency in the UI component keep a tinro FormPage in renderer part that is just delegating the calls fixes containers#6920 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
What does this PR do?
remove tinro dependency to include it in the UI library
keep a tinro FormPage in renderer part that is just delegating the calls
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #6920
How to test this PR?