Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid race condition by not running exec/start twice #1966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xNinjaKittyx
Copy link

When running with the lifecycle labels, this error is popping up at every interval/upgrade

time="2024-04-22T19:16:37Z" level=info msg="Command output:\nError: Exec command c37bb52a3fa2dd1489baf9f92ab17738ec0095b2f86afd9d27b75beee3bf2e31 is already running"

Looking more into it, it seems like it's related to moby/moby#42408 which I originally found through nektos/act#627 which is fixed with nektos/act#702

I took the changes and applied similarly to watchtower. I ran it locally with my initial fail test, and it seems to be clean now.

I'm not a go dev, so apologies if I have missed something.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant