Merge pull request #118 from contentful/dl/fix-nil-string-serialization

Fix string serialization
contentful · Jan 3, 2017 · 8e8cb1b · 8e8cb1b
2 parents 003ce33 + 26cc62c
commit 8e8cb1b
Show file tree

Hide file tree

Showing 4 changed files with 216 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 # Change Log
 
 ## Unreleased
+### Fixed
+* Fixed Symbol/Text field serialization when value is `null` [#117](https://github.com/contentful/contentful.rb/issues/117)
 
 ## 1.2.1
 ### Added

diff --git a/lib/contentful/resource.rb b/lib/contentful/resource.rb
@@ -18,7 +18,7 @@ module Resource
     # @private
     # rubocop:disable Style/DoubleNegation
     COERCIONS = {
-      string:  ->(v) { v.to_s },
+      string:  ->(v) { v.nil? ? nil : v.to_s },
       integer: ->(v) { v.to_i },
       float:   ->(v) { v.to_f },
       boolean: ->(v) { !!v },

diff --git a/spec/entry_spec.rb b/spec/entry_spec.rb
@@ -313,4 +313,16 @@ def test_dump(nyancat)
       end
     end
   end
+
+  describe 'issues' do
+    it 'Symbol/Text field with null values should be serialized as nil - #117' do
+      vcr('entries/issue_117') {
+        client = create_client(space: '8jbbayggj9gj', access_token: '4ce0108f04e55c76476ba84ab0e6149734db73d67cd1b429323ef67f00977e07', dynamic_entries: :auto)
+        entry = client.entries.first
+
+        expect(entry.nil).to be_nil
+        expect(entry.nil).not_to eq ''
+      }
+    end
+  end
 end
diff --git a/spec/fixtures/vcr_cassettes/entries/issue_117.yml b/spec/fixtures/vcr_cassettes/entries/issue_117.yml