Do not report user aborted requests as errors

contiamo · Dec 11, 2019 · 9b75814 · 9b75814
1 parent e1e9dae
commit 9b75814
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/useGet.tsx b/src/useGet.tsx
@@ -122,6 +122,11 @@ async function _fetchData<TData, TError, TQueryParams>(
 
     setState({ ...state, error: null, loading: false, data: resolve(data) });
   } catch (e) {
+    // avoid state updates when component has been unmounted
+    // and when fetch/processResponse threw an error
+    if (signal.aborted) {
+      return;
+    }
     setState({
       ...state,
       loading: false,

diff --git a/src/useMutate.tsx b/src/useMutate.tsx
@@ -126,6 +126,12 @@ export function useMutate<
       try {
         data = resolve ? resolve(rawData) : rawData;
       } catch (e) {
+        // avoid state updates when component has been unmounted
+        // and when fetch/processResponse threw an error
+        if (signal.aborted) {
+          return;
+        }
+
         const error = {
           data: e.message,
           message: `Failed to resolve: ${e.message}`,