Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Security audit #104

Merged
merged 6 commits into from
Mar 15, 2019
Merged

Security audit #104

merged 6 commits into from
Mar 15, 2019

Conversation

stereobooster
Copy link
Contributor

Why

@contiamo-ci
Copy link

contiamo-ci commented Mar 14, 2019

Warnings
⚠️

❗ Big PR

Generated by 🚫 dangerJS

Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's red 🤔

@stereobooster stereobooster self-assigned this Mar 14, 2019
@stereobooster
Copy link
Contributor Author

@TejasQ green.

TejasQ
TejasQ previously approved these changes Mar 14, 2019
@TejasQ
Copy link
Contributor

TejasQ commented Mar 14, 2019

Maybe let’s validate this with a canary release and test in the product?

@stereobooster
Copy link
Contributor Author

npm build

src/Poll.tsx(343,10): error TS2322: Type '{ requestOptions: {} | {} | { body?: string | Blob | ArrayBufferView | ArrayBuffer | FormData | URLSearchParams | ReadableStream<Uint8Array> | null | undefined; cache?: "default" | ... 5 more ... | undefined; ... 10 more ...; window?: any; } | { ...; } | { ...; } | { ...; }; ... 11 more ...; onError: (err: any, retr...' is not assignable to type 'Partial<Pick<Readonly<PollProps<TData, TError, TQueryParams> & InjectedProps> & Readonly<{ children?: ReactNode; }>, "resolve" | "wait" | "base" | "interval">>'.\n  Types of property 'resolve' are incompatible.\n    Type '((data: any) => any) | ((data: any) => Promise<any>) | ((data: any, prevData: TData | null) => TData)' is not assignable to type '((data: any, prevData: TData | null) => TData) | undefined'.\n      Type '(data: any) => Promise<any>' is not assignable to type '(data: any, prevData: TData | null) => TData'.\n        Type 'Promise<any>' is not assignable to type 'TData'.\n

but why our tests doesn't catch it 🤔

@stereobooster
Copy link
Contributor Author

@TejasQ restful-react@7.2.0-5feeea4 @ canary

@TejasQ
Copy link
Contributor

TejasQ commented Mar 15, 2019

image

image

@stereobooster are you sure about the canary?

@stereobooster
Copy link
Contributor Author

@TejasQ you're right

You do not have permission to publish "restful-react"

@TejasQ
Copy link
Contributor

TejasQ commented Mar 15, 2019

Fixed. @stereobooster please publish.

@TejasQ TejasQ merged commit f6ee31c into master Mar 15, 2019
@TejasQ TejasQ deleted the security-audit branch March 15, 2019 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants