This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Improve the error layer #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejasQ
previously requested changes
Aug 24, 2018
There was a problem hiding this comment.
I think the usage of the isError flag is a little bit of an anti-pattern: the control flow is described using async/await mimicking synchronous flow, yet there is await processResponse().catch here.
Consider wrapping this in a try/catch instead. This would also allow you to remove the isError flag and the mutation thereof.
TejasQ
approved these changes
Aug 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Sometime, in the beautiful nginx world, we can have this kind of non-sense response:
That result with a proper explosion because we trying to parse html as json.
This PR add an extra layer of security for this kind of cases -> "never trust server response" 😈