Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Improve the error management for Poll #46

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Improve the error management for Poll #46

merged 2 commits into from
Sep 13, 2018

Conversation

fabien0102
Copy link
Contributor

Why

Because as a noob I've commited a .skip on this part 😆 and also because we have a lot of foggy spots on this part.

The idea is to be as close as possible of Get regarding the comportement and also continue polling after an error (so the until props is really useful)

@fabien0102 fabien0102 self-assigned this Sep 12, 2018
@TejasQ
Copy link
Contributor

TejasQ commented Sep 13, 2018

You've got to be kidding me. I should have caught this in the review!

@TejasQ
Copy link
Contributor

TejasQ commented Sep 13, 2018

Using yarn as the package manager for this project is a real problem. Our .prettierrcs are not synced because of yarnpkg/yarn#5476, since the postinstall from https://github.com/contiamo/operational-scripts doesn't execute. :(

We should either:

  • a) drop yarn and use npm,
    • This means a large commit of changing lockfiles
  • b) fix it on yarn
  • c) npm install @operational/scripts and then remove package-lock.json.

I added a commit here that formats everything correctly since your initial commit added some formatting already.

From this point on, I don't think we should have any more formatting discrepancies in diffs.

Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TejasQ TejasQ merged commit 2b90bea into master Sep 13, 2018
@TejasQ TejasQ deleted the poll-errors branch September 13, 2018 01:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants