Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Update implementation for cleaner mutations #7

Merged
merged 6 commits into from
Jul 10, 2018
Merged

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Jul 9, 2018

Why

  • We were not resetting error states on refetch (!)
  • We decided to rename host to base
  • I was incorrectly using setState (thanks, @Xiot!)
  • lint-staged was incorrectly configured and did not work on precommit.
  • <Get lazy and then calling post inside its body seemed like a workaround.
  • Errors were being caught and handled inside the library when instead how they're handled should be up to consumers.
  • index.tsx exported a whole bunch of other things, while containing the GET definition.

Changes

This will result in a new major version because of API breakage.

@TejasQ TejasQ self-assigned this Jul 9, 2018
@TejasQ TejasQ requested a review from a team July 9, 2018 13:07
@TejasQ TejasQ changed the title Enhance/cleanup WIP: Enhance/cleanup Jul 9, 2018
src/index.tsx Outdated
@@ -86,8 +86,10 @@ export interface GetComponentProps<T> {
/**
* An escape hatch and an alternative to `path` when you'd like
* to fetch from an entirely different URL..
*
* @deprecated Deprecated in favor of a `base` prop (https://github.com/contiamo/restful-react/issues/4)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deprecation warning doesn't make sense on the base prop.

@TejasQ TejasQ changed the base branch from master to release/4.0.0 July 10, 2018 10:02
@TejasQ TejasQ changed the base branch from release/4.0.0 to next July 10, 2018 10:07
@TejasQ TejasQ mentioned this pull request Jul 10, 2018
@TejasQ TejasQ changed the title WIP: Enhance/cleanup Update implementation for cleaner mutations Jul 10, 2018
@TejasQ TejasQ merged commit 04a2c4b into next Jul 10, 2018
@TejasQ TejasQ deleted the enhance/cleanup branch July 10, 2018 10:19
This was referenced Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants