Datepicker input #1096
Closed
Datepicker input #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MartinKokesCz Please check Phpstan issues related to changes. I will fix the rest of codesniffer/phpstan issues. |
|
@MartinKokesCz Please, rebase, I fixed all related issues in |
|
@radimvaculik maybe it is ready now ? |
radimvaculik
requested changes
Aug 30, 2023
src/Column/ColumnDateTime.php
Outdated
| @@ -47,4 +47,9 @@ public function setFormat(string $format): self | |||
| return $this; | |||
| } | |||
|
|
|||
| public function getFormat(): string | |||
There was a problem hiding this comment.
No need anymore. @MartinKokesCz
There was a problem hiding this comment.
@radimvaculik ok, removed. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #946 I have prepared the simple HTML input type="date" for date and date range filter.
You can try it with my fork of datagrid-skeleton
https://github.com/MartinKokesCz/datagrid-skeleton/tree/next