dbus: add context to open functions #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
Sep 10, 2020
|
Thanks for the PR! I have a doubt about context wiring, I've left a comment in review. |
|
I'd be happy to see a "Deprecated" label on all the old methods, see https://github.com/golang/go/wiki/Deprecated. |
lucab
changed the title
lucab
reviewed
Sep 10, 2020
|
@vaspahomov thanks, this looks fine to merge. Can you please squash your commits into a single one, and update the title as I did for the PR? |
|
@lucab done |
lucab
approved these changes
Sep 10, 2020
This was referenced Sep 10, 2020
This was referenced Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows passing context value to dbus connection opening functions.