Skip to content
This repository has been archived by the owner on Feb 5, 2020. It is now read-only.

modules/aws: add dep from aws_eip.nat_eip to aws_internet_gateway.igw #1053

Merged
merged 2 commits into from
Jun 12, 2017
Merged

modules/aws: add dep from aws_eip.nat_eip to aws_internet_gateway.igw #1053

merged 2 commits into from
Jun 12, 2017

Conversation

s-urbaniak
Copy link
Contributor

This prevents the internet gateway to be deleted before Elastic IPs which
can cause destroy failure.

Fixes #1017

Sergiusz Urbaniak added 2 commits June 12, 2017 15:30
modules/aws: add dep from aws_eip.nat_eip to aws_internet_gateway.igw
a4fa2c5 
This prevents the internet gateway to be deleted before Elastic IPs
which can cause destroy failure.

Fixes coreos#1017
modules/aws: remove explicit dep from nat_gw to nat_eip
5c70ec8 
It is expressed in allocation_id already and can cause the graph
optimization to be distorted.
@s-urbaniak
Copy link
Contributor Author

retest this please

2 similar comments
@s-urbaniak
Copy link
Contributor Author

retest this please

@s-urbaniak
Copy link
Contributor Author

retest this please

@s-urbaniak
Copy link
Contributor Author

CI failure on baremetal is unrelated:


null_resource.bootstrap: Still creating... (5m10s elapsed)
null_resource.bootstrap (remote-exec): Job for tectonic.service canceled.
Error applying plan:

1 error(s) occurred:

* null_resource.bootstrap: 1 error(s) occurred:

* Script exited with non-zero exit status: 1

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

@s-urbaniak
Copy link
Contributor Author

retest this please

@s-urbaniak
Copy link
Contributor Author

another unrelated CI failure:


--- FAIL: TestCluster (479.05s)
    --- PASS: TestCluster/APIAvailable (142.19s)
    	k8s_test.go:73: Waiting 15m0s for API server to become available
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:305: Waiting 10s after failed attempt to connect to API server. Error was: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/version: EOF
    	k8s_test.go:80: API server is available.
    --- FAIL: TestCluster/AllNodesRunning (87.56s)
    	k8s_test.go:220: expected 7 nodes got 0
    	k8s_test.go:212: node ip-10-0-12-116.us-east-2.compute.internal not ready
    	k8s_test.go:220: expected 7 nodes got 1
    	k8s_test.go:212: node ip-10-0-12-116.us-east-2.compute.internal not ready
    	k8s_test.go:220: expected 7 nodes got 1
    	k8s_test.go:212: node ip-10-0-12-116.us-east-2.compute.internal not ready
    	k8s_test.go:220: expected 7 nodes got 1
    	k8s_test.go:212: node ip-10-0-12-116.us-east-2.compute.internal not ready
    	k8s_test.go:220: expected 7 nodes got 1
    	k8s_test.go:212: node ip-10-0-12-116.us-east-2.compute.internal not ready
    	k8s_test.go:220: expected 7 nodes got 1
    	k8s_test.go:212: node ip-10-0-12-116.us-east-2.compute.internal not ready
    	k8s_test.go:220: expected 7 nodes got 1
    	k8s_test.go:208: node ip-10-0-12-116.us-east-2.compute.internal ready
    	k8s_test.go:212: node ip-10-0-30-129.us-east-2.compute.internal not ready
    	k8s_test.go:212: node ip-10-0-51-251.us-east-2.compute.internal not ready
    	k8s_test.go:212: node ip-10-0-64-15.us-east-2.compute.internal not ready
    	k8s_test.go:212: node ip-10-0-65-21.us-east-2.compute.internal not ready
    	k8s_test.go:220: expected 7 nodes got 5
    	k8s_test.go:202: could not list nodes: etcdserver: request timed out
    --- PASS: TestCluster/GetLogs (174.78s)
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to find tectonic-identity pod (found pods in tectonic-system: )
    	k8s_test.go:132: Failed to get Pod logs with error:  failed to get pod logs: container "tectonic-identity" in pod "tectonic-identity-3240565221-269tx" is waiting to start: ContainerCreating
    --- PASS: TestCluster/AllPodsRunning (3.38s)
    	k8s_test.go:105: pod tectonic-system/prometheus-operator-469249970-zfp68 not running
    	k8s_test.go:105: pod tectonic-system/tectonic-console-962128392-b9hx8 not running
    	k8s_test.go:105: pod tectonic-system/tectonic-console-962128392-q9nl0 not running
    	k8s_test.go:105: pod tectonic-system/tectonic-identity-3240565221-418h0 not running
    --- PASS: TestCluster/KillAPIServer (71.13s)
    	k8s_test.go:258: old API server kube-apiserver-38b0w still running
    	k8s_test.go:258: old API server kube-apiserver-38b0w still running
    	k8s_test.go:258: old API server kube-apiserver-38b0w still running
    	k8s_test.go:252: get apiserver pod: Get https://aws-pr-1053-5012345678901234-api.tectonic.dev.coreos.systems:443/api/v1/namespaces/kube-system/pods?labelSelector=k8s-app%3Dkube-apiserver: net/http: TLS handshake timeout
    	k8s_test.go:258: old API server kube-apiserver-38b0w still running

@s-urbaniak
Copy link
Contributor Author

retest this please

alexsomesan
alexsomesan approved these changes Jun 12, 2017
View reviewed changes
Copy link
Contributor

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Discussed the options offline with @s-urbaniak.

@alexsomesan alexsomesan merged commit 6ca2ff3 into coreos:master Jun 12, 2017
@s-urbaniak s-urbaniak mentioned this pull request Jun 12, 2017
Closed
6 tasks
@Quentin-M
Copy link
Contributor

Thank you!

@ggreer
Copy link
Contributor

ggreer commented Jun 12, 2017

I'm pretty sure this fixes #949. Looks like @kans was right about the cause being hashicorp/terraform#4849

@ggreer ggreer mentioned this pull request Jun 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-urbaniak @Quentin-M @ggreer @alexsomesan