This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
*/config: compute service k8s IPs #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
Wooops I had a local branch hah. Looks pretty similar (usage of output..)! Cool! |
|
I think we could drop it entirely the config.tf variable. What do you think? |
|
I agree, we could drop it entirely. Let me change the PR accordingly. |
|
ok to test |
|
tested with both experimental/non-experimental on AWS. |
|
testing now on baremetal |
|
tested successfully on baremetal |
|
/cc @ggreer FYI for UI changes. This PR is backwards compatible but TF now only respects the service cidr setting. From the frontend-side we can now remove the cidr calculation. |
|
Nice! |
This was referenced May 19, 2017
alekssaul
pushed a commit
to alekssaul/tectonic-installer
that referenced
this pull request
May 30, 2017
alekssaul
added a commit
to alekssaul/tectonic-installer
that referenced
this pull request
May 31, 2017
Add changes in coreos#767 for VMware
Merged
alekssaul
added a commit
to alekssaul/tectonic-installer
that referenced
this pull request
May 31, 2017
Add changes in coreos#767 for VMware
alekssaul
added a commit
to alekssaul/tectonic-installer
that referenced
this pull request
May 31, 2017
Add changes in coreos#767 for VMware
s-urbaniak
pushed a commit
that referenced
this pull request
Jun 1, 2017
* Initial VMware Support * Always invoke terraform get to ensure we have the necessary modules (#591) * Makefile: add vmware docs-examples * Run make docs for VMware updates To address; #639 (comment) * Run terraform fmt on VMware content run `terraform fmt ./platforms/vmware/` , `terraform fmt ./modules/vmware/etcd` , `terraform fmt ./platforms/vmware/nodes` to address #639 (comment) * Variables cleanup and change ssh variable - cleanup variables.tf and run `make examples` to address; #639 (comment) - run `make docs` - update `tectonic_ssh_authorized_key` to `tectonic_vmware_ssh_authorized_key ` to address #639 (comment) * Fix Makefile conflict with vmware branch * vmware: remove redundant bootkube content_hash variable Related to #575 * vmware: remove username secrets from variables.tf Removes VMware Username and Password variables from variables.tf. User will be prompted to enter credentials at terraform execution time, such as. ``` provider.vsphere.password The user password for vSphere API operations. Enter a value: provider.vsphere.user The user name for vSphere API operations. Enter a value: ``` * VMware: fix Master CPU/memory vars issue Master Node provisioning was utilizing worker CPU and memory variables. * vmware examples - re-run make docs examples * vmware: compute service k8s IPs Add changes in #767 for VMware * vmware: Replace all occurences of path.cwd Applies d3e0a6a into vmware platform * vmware: Bump bootkube v0.4.4 & hyperkube v1.6.4_coreos.0 Applies requirements for 5941fda on VMware Platform * vmware: run terraform fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #642