Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MANIFEST.MF outside Maven/Gradle #35

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Move MANIFEST.MF outside Maven/Gradle #35

merged 1 commit into from
Dec 16, 2021

Conversation

alvdavi
Copy link
Contributor

@alvdavi alvdavi commented Dec 16, 2021

Keep different entries for Created-By so they can be identified. Implementation-Version is read from version.txt in gradle, but still present in the pom.xml for maven.

@alvdavi alvdavi marked this pull request as ready for review December 16, 2021 05:40
@alvdavi alvdavi merged commit 97c7e96 into corretto:main Dec 16, 2021
@alvdavi alvdavi deleted the manifest branch December 16, 2021 06:04
@alvdavi alvdavi mentioned this pull request Dec 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutkerd lutkerd lutkerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvdavi @lutkerd