-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maven project support #9
Conversation
Hey @yishaigalatzer, since the project has been converted to a Gradle project, this PR is no longer necessary since the publish to Maven can be achieved using the Gradle project. |
Okay, discussing further with @yishaigalatzer looks like we do want a Maven version of this project as well for distributing outside of Maven central. |
9dab83b
to
0aa694b
Compare
Updated the project to mirror the current gradle build file |
0aa694b
to
5fb1998
Compare
This PR is trying to undo #27, probably unintended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure this PR does not rollback #27
Rollback was to support older versions of ASM. Discussed offline, will update this once the ASM lib is included directly in the project. |
19926c3
to
a13c4ed
Compare
a13c4ed
to
b10334d
Compare
Issue #, if available:
Description of changes:
This change allows this project to be built using Maven. Project build/config based on the
build.gradle
file.Tested using
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.