-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NO_STD switch #154
Add NO_STD switch #154
Conversation
Adds the NO_DEFAULT_LIBRARIES switch to Corrosion, allowing building no_std crates in CMake without linking additional libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I just wonder if the option should not be called just NO_STD
to match the rust attribute.
Or is that a different thing?
Does it work for a no_std crate that uses the alloc crate?
|
|
Thanks for the PR. I see you also touched |
Here you go. Not very pretty, but it works. |
This variable was introduced in corrosion-rs#154. Since then we have unified how default libraries are added to the linker line, and the legacy generator does not have this option anymore. So this unused variable can be safely removed.
Adds the NO_STD switch to Corrosion, allowing building
no_std crates in CMake without linking additional libraries.
Closes #153