Do not set LIBRARY_PATH on macOS 13 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting LIBRARY_PATH on macos 13 causes issues when compiling rust crates with rust dependencies compiling modern C++ in their build script. This can be reproduced without Corrosion by running: ``` LIBRARY_PATH=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib \ cargo rustc --lib --package cxxbridge-crate --manifest-path \ /path/to/cxxbridge/rust/Cargo.toml -- -Cdefault-linker-libraries=yes ``` Without LIBRARY_PATH the build completes without problems, but with the environment variable set the build script errors, since the C++ code contains e.g. C++11 extensions. Since on macos-13 everything works fine when removing LIBARY_PATH remove it for macos 13, but keep it for previous macos versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting LIBRARY_PATH on macos 13 causes issues when compiling rust
crates with rust dependencies compiling modern C++ in their build script.
This can be reproduced without Corrosion by running:
Without LIBRARY_PATH the build completes without problems, but with the
environment variable set the build script errors, since the C++ code
contains e.g. C++11 extensions.
Since on macos-13 everything works fine when removing LIBARY_PATH remove
it for macos 13, but keep it for previous macos versions.