Fix imported location target property when target contains dashes and CORROSION_RESPECT_OUTPUT_DIRECTORY is true #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CORROSION_RESPECT_OUTPUT_DIRECTORY is true The regex to determine the name of the actual library target tries to strip the -static or -shared suffix did not allow for dashes in the name. Since the regexp closes with a $, the suffix should only match at the very end and we can allow any character before the last dash. Fixes #321
|
The test passes for me locally on macOS. Is this known to be a flakey test somehow? |
jschwe
approved these changes
Feb 17, 2023
|
Thanks for the review & merge. Would it be possible to tag a new release of Corrosion that includes this? We'd love to use a tag instead of a sha1 :) |
Sure, I released v0.3.3 and updated v0.3 to point to v0.3.3. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex to determine the name of the actual library target tries to strip the -static or -shared suffix did not allow for dashes in the name. Since the regexp closes with a $, the suffix should only match at the very end and we can allow any character before the last dash.
Fixes #321