corrosion_import_crate: Fix PROFILE argument in combination with CRATES #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not forward the PROFILE argument from `corrosion_import_crate` to `_generator_add_cargo_targets`.
|
Thanks for the PR! Yes, it's a leftover from 411a7f3, where the |
jschwe
changed the title
jschwe
added a commit
to jschwe/corrosion
that referenced
this pull request
Apr 3, 2024
…ES (corrosion-rs#496) Do not forward the PROFILE argument from `corrosion_import_crate` to `_generator_add_cargo_targets`. The PROFILE argument is forwarded via a target property set during `corrosion_import_crate`. The remaining argument forwarding can cause issues when combined with a multi-value-argument, such as `CRATES`. --------- Co-authored-by: Jonathan Schwender <schwenderjonathan@gmail.com> (cherry picked from commit d5bdbfa)
jschwe
added a commit
that referenced
this pull request
Apr 3, 2024
…ES (#496) Do not forward the PROFILE argument from `corrosion_import_crate` to `_generator_add_cargo_targets`. The PROFILE argument is forwarded via a target property set during `corrosion_import_crate`. The remaining argument forwarding can cause issues when combined with a multi-value-argument, such as `CRATES`. --------- Co-authored-by: Jonathan Schwender <schwenderjonathan@gmail.com> (cherry picked from commit d5bdbfa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not forward the PROFILE argument from
corrosion_import_crateto_generator_add_cargo_targets.Closes #495.