cmake export (find_package) becomes portable #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, sounds reasonable.
Can I assume you tested the fix and can confirm it works with conan? |
Yes, tested with cmake 3.26.3 in conan. I am able to consume corrosion now via conan (by using env variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently the cmake export
CorrosionConfig.cmakeadds a hardcoded path (CMAKE_INSTALL_FULL_DATADIR) toCMAKE_MODULE_PATH. Unfortunately this path is only valid during build time of corrosion.If the resulting package is shipped (e.g. via a package manager like conan), then the path and therefore also the corrosion package becomes invalid.
Solution:
Instead, the import prefix of the package (
PACKAGE_PREFIX_DIR) is used.