Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvc: handle flags that come from native-static-libs #511

Merged
merged 3 commits into from
Apr 26, 2024

Commits on Apr 26, 2024

  1. msvc: handle flags that come from native-static-libs

    As of https://github.com/rust-lang/rust/pull/122268/files, rust emits /defaultlib:msvcrt in native-static-libs
    
    This ends up in INTERFACE_LINK_LIBRARIES, and then ninja thinks it's a file:
    
    ninja: error: '/defaultlib:msvcrt', needed by 'cpp-exe.exe', missing and no known rule to make it
    
    This check to see if libraries start with a slash, and then assuming that they are a flag, and putting those in INTERFACE_LINK_OPTIONS instead. If there is some better way to detect flags, I'm all for it. We could also have it have anything that starts with `-` but not start with `-l` be detected as a flag, but that seems a bit more likely to be disruptive.
    
    I checked commandlines and it does indeed get propaged properly to the commandline.
    russelltg committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    26d5e43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91232d9 View commit details
    Browse the repository at this point in the history
  3. add line in RELEASES.md

    russelltg committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    d4ad661 View commit details
    Browse the repository at this point in the history