Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

passthrough #40

Merged
merged 4 commits into from
Jun 10, 2024
Merged

passthrough #40

merged 4 commits into from
Jun 10, 2024

Conversation

till
Copy link
Collaborator

@till till commented Apr 26, 2024

  • Fix(auth): use crypto/subtle to compare strings
  • Update(gateway): support passthrough

@till
Fix(auth): use crypto/subtle to compare strings
37cfb0e 
Related: cortexproject#37
Signed-off-by: till <till@php.net>
@till
Update(gateway): support passthrough
6fa8990 
For: cortexproject#36
Signed-off-by: till <till@php.net>
@till
Copy link
Collaborator Author

till commented Apr 26, 2024

Should probably come after #39 (if you like that).

friedrichg
friedrichg reviewed Jun 10, 2024
View reviewed changes
gateway/middleware.go Outdated Show resolved Hide resolved
friedrichg
friedrichg approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this. Thanks!

@friedrichg friedrichg merged commit 2c53fa7 into cortexproject:main Jun 10, 2024
2 checks passed
@till till deleted the passthrough branch June 10, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichg friedrichg friedrichg approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@till @friedrichg