Add ADR-028 implementation and test CosmWasm contract addresses #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Jul 28, 2021
| describe("adr28", () => { | ||
| describe("moduleAddressRaw", () => { | ||
| it("can be used for wasm contract address derivation", () => { | ||
| function contractAddressRaw(codeId: number, contractId: number): Uint8Array { |
There was a problem hiding this comment.
very cool. glad to see this cross-test
There was a problem hiding this comment.
did you want to expose this function not just in tests? (but i guess in cosmwasm package?)
The slice(0, 20) is unique to our 0.42-compatible code. The 0.43 sdk has 32 byte addresses 😱 (actually a mix between 20 and 32 I think) hope that doesn't break other tests
There was a problem hiding this comment.
This is just to test the generic ADR-28 implementation. Turns out no CosmWasm client needs to know how contract addresses are generated. They just use them. So I don't see a point in exposing that.
|
Closing as not needed. See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.