Skip to content

Commit

Permalink
test: fix flakiness due to duplicate denoms (#15223)
Browse files Browse the repository at this point in the history
  • Loading branch information
mark-rushakoff committed Mar 1, 2023
1 parent 41c8529 commit e33c5a7
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions tests/integration/bank/keeper/deterministic_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,13 @@ func TestGRPCQuerySpendableBalances(t *testing.T) {

rapid.Check(t, func(rt *rapid.T) {
addr := testdata.AddressGenerator(rt).Draw(rt, "address")
numCoins := rapid.IntRange(1, 10).Draw(rt, "num-count")
coins := make(sdk.Coins, 0, numCoins)

for i := 0; i < numCoins; i++ {
// Denoms must be unique, otherwise sdk.NewCoins will panic.
denoms := rapid.SliceOfNDistinct(rapid.StringMatching(denomRegex), 1, 10, rapid.ID[string]).Draw(rt, "denoms")
coins := make(sdk.Coins, 0, len(denoms))
for _, denom := range denoms {
coin := sdk.NewCoin(
rapid.StringMatching(denomRegex).Draw(rt, "denom"),
denom,
sdk.NewInt(rapid.Int64Min(1).Draw(rt, "amount")),
)

Expand All @@ -171,7 +172,7 @@ func TestGRPCQuerySpendableBalances(t *testing.T) {
err := banktestutil.FundAccount(f.bankKeeper, f.ctx, addr, coins)
assert.NilError(t, err)

req := banktypes.NewQuerySpendableBalancesRequest(addr, testdata.PaginationGenerator(rt, uint64(numCoins)).Draw(rt, "pagination"))
req := banktypes.NewQuerySpendableBalancesRequest(addr, testdata.PaginationGenerator(rt, uint64(len(denoms))).Draw(rt, "pagination"))
testdata.DeterministicIterations(f.ctx, t, req, f.queryClient.SpendableBalances, 0, true)
})

Expand Down

0 comments on commit e33c5a7

Please sign in to comment.