Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unneeded imports #10742

Closed
4 tasks
faddat opened this issue Dec 12, 2021 · 1 comment
Closed
4 tasks

Unneeded imports #10742

faddat opened this issue Dec 12, 2021 · 1 comment

Comments

@faddat
Copy link
Contributor

faddat commented Dec 12, 2021 •
edited
Loading

Summary of Bug

The cosmos-sdk imports tendermint as far back as v0.34.0-rc4
...and itself (current master branch) but at v0.44.0
...and a lot of other odd stuff.

Version

Everything I have checked except v0.44.5

Steps to Reproduce

cosmos/gaia#1099

https://twitter.com/gadikian/status/1469512833809678342

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@faddat faddat mentioned this issue Dec 12, 2021
Closed
19 tasks
@tac0turtle
Copy link
Member

closing this as we talked about it in another pr. Thank you for diving into this. we have a pr to fix dependency management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unnecessary imports faddat/basecoin
2 participants
@faddat @tac0turtle