Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary imports #10743

Closed
wants to merge 4 commits into from
Closed

fix: unnecessary imports #10743

wants to merge 4 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 12, 2021

  • removed the independent go.mod files from db
  • removed independent go.mod and go.sum from groups module
  • Solves unnecessary import issues and removes go.mod and go.sum from groups and db

Description

Closes: #10742

Removes independent go.mod and go.sum from db and groups, purges unnecessary imports.

cosmos/gaia#1099


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat changed the title Fix unnecessary imports fix: unnecessary imports Dec 12, 2021
@faddat
Copy link
Contributor Author

faddat commented Dec 12, 2021

Seems the build system expects these modules to have their own go.mod and go.sum

generally speaking, and for ergonomics with the majority of code editing suites (goland, vscode) you want exactly one of each of go.mod and go.sum, so I'd suggest that we fix the build system, not make it harder to work on the cosmos-sdk.

@tac0turtle
Copy link
Member

why are you removing the go.mods from db and groups? this was done on purpose.

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple go.mods is on purpose. lets not remove them

@faddat faddat closed this Dec 12, 2021
@faddat
Copy link
Contributor Author

faddat commented Dec 12, 2021

I'll revise.

This should really be treated more like an exploration of the issue, and represented my first set of guesses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unneeded imports
2 participants