State sync not working without having state sync snapshotting enabled

[gjermundgaraba]

Summary of Bug

Syncing a node with state sync does not currently work, unless you have snapshotting enabled.
The error looks like this:

INF Offering snapshot to ABCI app format=2 hash="..." height=1337 module=statesync
ERR snapshot manager not configured
ERR State sync failed err="state sync aborted" module=statesync

This bug appears to have been introduced in v0.46 when baseapp/options.go got a change to how the snapshot is configured.

Previously these things were configured separately and you could set up the snapshot manager without a snapshot interval != 0. Now the snapshot manager is not set if the snapshot interval is set to 0.

cosmos-sdk/baseapp/options.go

Lines 212 to 222 in a114313

	func (app *BaseApp) SetSnapshot(snapshotStore *snapshots.Store, opts snapshottypes.SnapshotOptions) {
	if app.sealed {
	panic("SetSnapshot() on sealed BaseApp")
	}
	if snapshotStore == nil || opts.Interval == snapshottypes.SnapshotIntervalOff {
	app.snapshotManager = nil
	return
	}
	app.cms.SetSnapshotInterval(opts.Interval)
	app.snapshotManager = snapshots.NewManager(snapshotStore, opts, app.cms, nil, app.logger)
	}

Version

v0.46.0

[lesnikutsa]

I met such error in Gitopia. At first I thought that this was how it should be, but now I see that this is a mistake.

[Lockwarr]

From what I read here, it seems that enabling snapshots in app.toml is meant to make state sync work. So is it a bug or a feature ??

[BitCannaGlobal]

So temporally "fix" (in the client side):

sed -E -i -s 's/snapshot-interval = 0/snapshot-interval = 10000/' $HOME/.bcna/config/app.toml

StateSync as client doesn't work if its server file is not configured with snapshot-interval > 0 (is not active)

Only for reference, we have added to our StateSync script and works:
https://github.com/BitCannaGlobal/cosmos-statesync_client/blob/main/statesync_DEVNET-5_client_linux_new.sh