Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure TxFactory has acc & seq fields when simulating tx in generate-only mode #11313

Merged
merged 4 commits into from
Mar 3, 2022

Conversation

clevinson
Copy link
Contributor

@clevinson clevinson commented Mar 3, 2022

Description

On regen ledger when using the CLI I noticed that --gas auto does not work in --generate-only mode. I was able to reproduce it on Cosmos-SDK master with bank send msg's as well:

simd tx bank send $ADDR1 $ADDR2 10stake --generate-only --gas auto

Failed with the error:

Error: rpc error: code = InvalidArgument desc = account sequence mismatch, expected 2, got 0: incorrect account sequence: invalid request

After digging around on the SDK, I found that when broadcasting a tx we often call txf.Prepare() on the TxFactory to add acc number & sequence in case it isn't already set explicitly via CLI flags. However, we don't do this when calling txf.PrintUnsignedTx(). Usually this isn't a problem, but acc numbers & sequences are actually required when simulating a tx for calculating gas (e.g. if --gas auto is set).

This PR fixes the above issue by running txf.Prepare() prior to simulating the transaction for gas calculation in --generate-only mode.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

should we backport to 0.45?

@tac0turtle tac0turtle merged commit 0a7ad01 into master Mar 3, 2022
@tac0turtle tac0turtle deleted the clevinson/fix-generate-only-gas-auto branch March 3, 2022 17:19
mergify bot pushed a commit that referenced this pull request Mar 3, 2022
…rate-only mode (#11313)

* fix: ensure TxFactory has acc no & seq when simulating tx in generate only mode

* add changelog

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
(cherry picked from commit 0a7ad01)

# Conflicts:
#	client/tx/factory.go
@amaury1093 amaury1093 mentioned this pull request May 23, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants