Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export genesis to stdout, not stderr #11844

Merged
merged 5 commits into from
May 2, 2022
Merged

fix: export genesis to stdout, not stderr #11844

merged 5 commits into from
May 2, 2022

Conversation

yaruwangway
Copy link
Contributor

Description

present app export genesis will export to stderr, not stdout, because cobra println default is to stderr

gaiad export > genesis_export.json will not work
gaiad export 2> genesis_export.json will work

the fix makes gaiad export to print to stdout.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt
Copy link
Member

Can you have a look at the tests?

@yaruwangway
Copy link
Contributor Author

Can you have a look at the tests?

ok

@yaruwangway
Copy link
Contributor Author

yaruwangway commented May 2, 2022

@julienrbrt , i changed the output to a defined output , otherwise output is stdout.
because the in the export_test.go the output is redefined by cmd.setout, this should make the tests pass.

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label May 2, 2022
@mergify mergify bot merged commit a187a1c into main May 2, 2022
@mergify mergify bot deleted the fix-export branch May 2, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants