Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move /proto/{modules} to their own modules #13382

Closed
wants to merge 1 commit into from

Conversation

julienrbrt
Copy link
Member

Description

Closes: #13363, #12003
Implements some ideas from #12003

WIP


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle
Copy link
Member

Lets not do this till after 0.47 please

@julienrbrt
Copy link
Member Author

Lets not do this till after 0.47 please

Alright! Closing for now!

@julienrbrt julienrbrt closed this Sep 25, 2022
@julienrbrt julienrbrt deleted the julien/proto branch September 25, 2022 09:47
@alexanderbez
Copy link
Contributor

Love the effort, but yeah let's do it after 0.47 -- good to have a PR as a reference though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPIC: Create buf registry for each extracted module
3 participants