Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor cleanup of types #13430

Merged
merged 4 commits into from
Oct 2, 2022
Merged

chore: minor cleanup of types #13430

merged 4 commits into from
Oct 2, 2022

Conversation

tac0turtle
Copy link
Member

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Merging #13430 (8ad22e2) into main (4fe7797) will decrease coverage by 1.77%.
The diff coverage is 28.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13430      +/-   ##
==========================================
- Coverage   55.87%   54.10%   -1.78%     
==========================================
  Files         646      645       -1     
  Lines       54895    55276     +381     
==========================================
- Hits        30675    29906     -769     
- Misses      21762    22977    +1215     
+ Partials     2458     2393      -65     
Impacted Files Coverage Δ
baseapp/grpcrouter.go 90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go 25.00% <ø> (ø)
baseapp/grpcserver.go 1.72% <ø> (ø)
baseapp/msg_service_router.go 85.29% <ø> (+4.41%) ⬆️
baseapp/options.go 67.92% <ø> (-0.60%) ⬇️
client/broadcast.go 54.54% <ø> (+2.99%) ⬆️
client/cmd.go 57.73% <ø> (ø)
client/config/toml.go 55.55% <ø> (ø)
client/context.go 54.49% <ø> (-1.79%) ⬇️
client/flags/flags.go 19.35% <ø> (-0.32%) ⬇️
... and 262 more

@tac0turtle tac0turtle marked this pull request as ready for review October 1, 2022 23:12
@tac0turtle tac0turtle requested a review from a team as a code owner October 1, 2022 23:12
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just two nits.

@julienrbrt julienrbrt merged commit c221d7f into main Oct 2, 2022
@julienrbrt julienrbrt deleted the marko/minor_types branch October 2, 2022 13:03
@aaronc
Copy link
Member

aaronc commented Oct 2, 2022

This should have been refactor! because it's breaking. chore should never be used when there are code changes I believe.

@tac0turtle tac0turtle added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Oct 2, 2022
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/evidence C:x/feegrant T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants