Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overwrite default denom in init cmd #13535

Merged
merged 6 commits into from
Oct 13, 2022
Merged

feat: overwrite default denom in init cmd #13535

merged 6 commits into from
Oct 13, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 13, 2022

Description

#9776 is not so useful, as it changes only the default denomination for the staking module.
More modules use sdk.DefaultBondDenom, such as gov, leading to a mix of stake and the chosen denomination.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review October 13, 2022 12:10
@julienrbrt julienrbrt requested a review from a team as a code owner October 13, 2022 12:10
@github-actions github-actions bot added C:CLI C:x/genutil genutil module issues labels Oct 13, 2022

genFile := config.GenesisFile()
overwrite, _ := cmd.Flags().GetBool(FlagOverwrite)
stakingBondDenom, _ := cmd.Flags().GetString(FlagStakingBondDenom)
defaultDenom, _ := cmd.Flags().GetString(FlagDefaultBondDenom)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #13535 (ce13a7e) into main (3a22a1e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #13535   +/-   ##
=======================================
  Coverage   53.92%   53.92%           
=======================================
  Files         643      643           
  Lines       55475    55464   -11     
=======================================
- Hits        29914    29910    -4     
+ Misses      23158    23152    -6     
+ Partials     2403     2402    -1     
Impacted Files Coverage Δ
types/staking.go 50.00% <ø> (ø)
x/genutil/client/cli/init.go 70.29% <100.00%> (+2.43%) ⬆️
x/group/keeper/keeper.go 56.64% <0.00%> (+0.39%) ⬆️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tac0turtle tac0turtle merged commit 89c65f4 into main Oct 13, 2022
@tac0turtle tac0turtle deleted the julien/denom branch October 13, 2022 16:24
@amitkarpe
Copy link

This is very useful, as every time we launch new chain we have to update genesis or app or config files manually or using jq/sed/dasel commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants