Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename migrations from v42, v43, v{SDK} to v1, v2, v{Consensus} #13772

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

julienrbrt
Copy link
Member

Description

While working on #13742, noticed an inconsistency in migrations naming.
This PR address that. Sort of continuation of #12579


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title refactor: rename migrations from v42, v43 to v1, v2 refactor: rename migrations from v42, v43, vSDK to v1, v2, vConsensus Nov 4, 2022
@julienrbrt julienrbrt changed the title refactor: rename migrations from v42, v43, vSDK to v1, v2, vConsensus refactor: rename migrations from v42, v43, v{SDK} to v1, v2, v{Consensus} Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #13772 (c988b7d) into main (39c5c07) will increase coverage by 0.62%.
The diff coverage is 74.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13772      +/-   ##
==========================================
+ Coverage   56.05%   56.67%   +0.62%     
==========================================
  Files         659      636      -23     
  Lines       57393    54552    -2841     
==========================================
- Hits        32171    30918    -1253     
+ Misses      22628    21129    -1499     
+ Partials     2594     2505      -89     
Impacted Files Coverage Δ
x/auth/keeper/migrations.go 0.00% <0.00%> (ø)
x/auth/migrations/v2/store.go 63.58% <ø> (ø)
x/auth/migrations/v3/store.go 78.57% <ø> (ø)
x/auth/migrations/v4/migrate.go 72.72% <ø> (ø)
x/auth/module.go 57.14% <0.00%> (ø)
x/authz/keeper/migrations.go 0.00% <0.00%> (ø)
x/authz/migrations/v2/keys.go 100.00% <ø> (ø)
x/authz/migrations/v2/store.go 70.45% <ø> (ø)
x/authz/module/module.go 17.94% <0.00%> (ø)
x/distribution/keeper/migrations.go 0.00% <0.00%> (ø)
... and 35 more

@github-actions github-actions bot removed the C:x/group label Nov 4, 2022
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utack. Thanks for the cleanup

@julienrbrt julienrbrt merged commit 7efeb82 into main Nov 7, 2022
@julienrbrt julienrbrt deleted the julien/migrations branch November 7, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants