Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: dockerfiles #14793

Merged
merged 6 commits into from
Jan 26, 2023
Merged

perf: dockerfiles #14793

merged 6 commits into from
Jan 26, 2023
+82 −77

Conversation

robert-zaremba
Copy link
Collaborator

@robert-zaremba robert-zaremba commented Jan 26, 2023 •
edited
Loading

Description

Reworked Docker files to organize them and speedup build:

  • much faster build time
  • no need to install build dependencies
  • "whitespace" cleanup in Makefile

Before (time to build from the ./Dockerfile):

  • fresh start: 2:54m
  • after changing app.go file: 2:11m
  • image size: 76.5M
  • build-env size: 3.4G

After:

  • fresh start: 2:27m
  • after changing app.go file: 1:13m
  • image size: 180M
  • build-env size: 3.88G

Checked:

  • main dockerfile
  • localnet-build-env, simd-env and simd-dvl

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added T: CI T: Performance Performance improvements tooling dev tooling within the sdk backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Jan 26, 2023
@robert-zaremba robert-zaremba requested a review from a team as a code owner January 26, 2023 14:41
@github-actions github-actions bot added C:Rosetta Issues and PR related to Rosetta Type: Build labels Jan 26, 2023
@robert-zaremba robert-zaremba changed the title Robert/dockerfiles perf: dockerfiles Jan 26, 2023
julienrbrt
julienrbrt approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@robert-zaremba
Copy link
Collaborator Author

Is it normal that the test-rosetta fails? This is tested only if something changed in rosetta.

@robert-zaremba
Copy link
Collaborator Author

Example of failing rosetta test: https://github.com/cosmos/cosmos-sdk/actions/runs/4016196074/jobs/6898898930

robert-zaremba
robert-zaremba commented Jan 26, 2023
View reviewed changes
Makefile
exit 1;\
else \
echo "\033[92mSwagger docs are in sync\033[0m";\
fi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanupd mix of spaces and tabs

@julienrbrt
Copy link
Member

julienrbrt commented Jan 26, 2023 •
edited
Loading

Is it normal that the test-rosetta fails? This is tested only if something changed in rosetta.

I don't think so, but it is as well failing on main: https://github.com/cosmos/cosmos-sdk/actions/runs/4017094584/jobs/6900997441.
cc @raynaudoe

tac0turtle
tac0turtle approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@julienrbrt julienrbrt merged commit be9bd7a into main Jan 26, 2023
@julienrbrt julienrbrt deleted the robert/dockerfiles branch January 26, 2023 20:21
mergify bot pushed a commit that referenced this pull request Jan 26, 2023
@robert-zaremba @mergify
perf: dockerfiles (#14793)
c14618d 
(cherry picked from commit be9bd7a)

# Conflicts:
#	CHANGELOG.md
#	Dockerfile
#	contrib/images/simd-env/Dockerfile
@mergify mergify bot mentioned this pull request Jan 26, 2023
Merged
julienrbrt added a commit that referenced this pull request Jan 26, 2023
@mergify @robert-zaremba @julienrbrt
perf: dockerfiles (backport #14793) (#14795)
33986a3 
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@webmaster128 webmaster128 mentioned this pull request Apr 3, 2023
Closed
@julienrbrt julienrbrt mentioned this pull request Apr 5, 2023
Merged
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@robert-zaremba @tsenart
perf: dockerfiles (cosmos#14793)
b4e2f77
@170210 170210 mentioned this pull request Jan 15, 2024
Closed
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:Rosetta Issues and PR related to Rosetta T: CI T: Performance Performance improvements tooling dev tooling within the sdk Type: Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-zaremba @julienrbrt @tac0turtle