Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modify interface to match comets #14904

Merged
merged 4 commits into from
Feb 4, 2023
Merged

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Feb 3, 2023

Description

the difference in return value on the method With breaks compatibility with Comet's logger interface


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner February 3, 2023 23:15
@github-actions github-actions bot added the C:log label Feb 3, 2023
log/go.mod Outdated Show resolved Hide resolved
@tac0turtle tac0turtle enabled auto-merge (squash) February 4, 2023 09:45
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 4, 2023
@tac0turtle tac0turtle merged commit 7c50238 into main Feb 4, 2023
@tac0turtle tac0turtle deleted the marko/loggerinterface branch February 4, 2023 11:04
@aaronc
Copy link
Member

aaronc commented Feb 7, 2023

It seems that adding a dependency on comet defeats the purpose of having this isolated go module with just a logger interface. If we have to add a transitive dependency on comet anyway then we should just use its logging package. The way we can get around this is to use a wrapper around comet's logger where the With method returns the interface from this pacakge.

@aaronc aaronc mentioned this pull request Feb 7, 2023
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants