Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moving value codecs to a single place #14912

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

tac0turtle
Copy link
Member

Description

This proposes moving the math value codec into types to reduce the dependency graph in math. Don't want to have collections as a dep for people who aren't using it in a small library

would love to hear feedback from @testinginprod, if this is okay


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod
Copy link
Contributor

I think the change makes sense to me, in my head initially I though that a collections codec should live where we declare the type so that developers can find it easily.

Otherwise another solution might be to declare every codec in the SDK in a single package. We just need to find a way to make the codecs findable by developers.

@tac0turtle
Copy link
Member Author

I think the change makes sense to me, in my head initially I though that a collections codec should live where we declare the type so that developers can find it easily.

Otherwise another solution might be to declare every codec in the SDK in a single package. We just need to find a way to make the codecs findable by developers.

I think for more used items yes, but generally would love to see a world where we don't use castTypes and other proto features in this way and only use native proto types.

@tac0turtle tac0turtle marked this pull request as ready for review February 5, 2023 20:18
@tac0turtle tac0turtle requested a review from a team as a code owner February 5, 2023 20:18
@testinginprod testinginprod self-requested a review February 6, 2023 08:35
@julienrbrt julienrbrt merged commit 8cf814f into main Feb 6, 2023
@julienrbrt julienrbrt deleted the marko/math_collections branch February 6, 2023 08:38
@julienrbrt
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants