fix: downgrade goleveldb (sims after CometBFT switch) #14952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
reviewed
Feb 8, 2023
| @@ -207,4 +207,5 @@ replace ( | |||
| // Fix upstream GHSA-h395-qcrw-5vmq vulnerability. | |||
| // TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409 | |||
| github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.8.1 | |||
| github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | |||
There was a problem hiding this comment.
facundomedica
changed the title
julienrbrt
approved these changes
Feb 8, 2023
julienrbrt
reviewed
Feb 8, 2023
19 tasks
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
13 tasks
siburu
added a commit
to siburu/yui-relayer
that referenced
this pull request
May 17, 2023
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
teddyknox
pushed a commit
to duality-labs/duality
that referenced
this pull request
Jul 4, 2023
This PR fixes two issues: - when running the chain in Docker the REST API was inaccessible - this was due to the default Cosmos app config (app.toml settings) specifying `localhost` in the new version instead of the previous version which specified `0.0.0.0` - when the REST API was accessible, all Msgs and queries threw a 500 internal server error response with the message: ``` failed to load state at height 123; version does not exist (latest height: 123) ``` where the height number was the current block number (which keeps increasing as the chain was still progressing) --- The solution to the "failed to load state" error was found by searching the error which lead to the issue and PR: - cosmos/cosmos-sdk#14949 - cosmos/cosmos-sdk#14952
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package syndtr/goleveldb is known to have issues, I propose we pin it to the version we were previously using (which is also the same that go-ethereum uses, which might make it the most tested version).
Related: ethereum/go-ethereum#25413
Closes: #14949
Other usages of this package:
v1.0.1-0.20200815110645-5c35d600f0ca
v1.0.1-0.20210819022825-2ae1ddf74ef7
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change