Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/tx): implement SIGN_MODE_DIRECT_AUX handler #15380

Merged
merged 13 commits into from
Mar 16, 2023

Conversation

kocubinski
Copy link
Member

@kocubinski kocubinski commented Mar 13, 2023

Description

Closes: #15169

This patch ports logic from x/auth/tx/direct_aux.go and x/auth/tx/direct_aux_test.go to this new API.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@kocubinski kocubinski marked this pull request as ready for review March 14, 2023 18:25
@kocubinski kocubinski requested a review from a team as a code owner March 14, 2023 18:25
}

if options.SignersContext == nil {
h.signersContext = signing.NewGetSignersContext(signing.GetSignersOptions{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to pass the file resolver into these options. I think it just requires us changing the options struct to use the correct interface

Copy link
Member Author

@kocubinski kocubinski Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit more what you mean?

Here a user could set GetSignersContext.protoFiles to whatever they want to by constructing it themselves and passing it in.

Edit: Are you saying that GetSignersContext ought to type protoFiles as the interface protodesc.Resolver instead of protoregistry.Files ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but if they pass in FileResolver but not GetSignersContext, the GetSignersContext should be constructed with that FileResolver. Generally FileResolver and TypeResolver should be propagated to any component that needs them because the probuf types in a scope should all be the same.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this will be a refactor to GetSignersContext then, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes a bit. We probably need a new interface that extends FileResolver

@kocubinski kocubinski requested a review from aaronc March 15, 2023 18:29
@amaury1093 amaury1093 enabled auto-merge (squash) March 16, 2023 09:13
@amaury1093 amaury1093 merged commit 4a35885 into main Mar 16, 2023
@amaury1093 amaury1093 deleted the kocubinski/sign-direct-aux branch March 16, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/tx SIGN_MODE_DIRECT_AUX handler
3 participants