Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(math): Add mutative api for NewIntFromBigInt #18030

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

hieuvubk
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@hieuvubk hieuvubk requested a review from a team as a code owner October 10, 2023 07:31
@julienrbrt julienrbrt changed the title Add mutative api for NewIntFromBigInt feat(math): Add mutative api for NewIntFromBigInt Oct 10, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tac0turtle
Copy link
Member

Hey, we discussed this and decided to pull the mutative api into another struct to separate immutable from mutable. We will create and issue and work on this. for now ill close this pr, stay tuned for the issue

@julienrbrt
Copy link
Member

Hi, we discussed internally, and we will wait for the API improvement mentioned here for math/v2.
If you still need this, please rebase and we will review again.

@julienrbrt julienrbrt added this pull request to the merge queue Nov 7, 2023
Merged via the queue into cosmos:main with commit e7e1c36 Nov 7, 2023
96 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants