fix(x/slashing/keeper): hoist non-changing addresses parsing out of redelegation loop #18035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
julienrbrt
added
the
backport/v0.50.x
…edelegation loop This change hoists out, the parsing of non-changing validator address and delegator address which before were being re-parsed in every loop of the redelegation entries, parsing them once and reusing the already parsed addresses. Fixes #18032
odeke-em
force-pushed
the
x-slashing-hoist-validator+delegator-address-parsing
branch
from
2db64a3
to
b78c272
Compare
julienrbrt
approved these changes
Oct 10, 2023
| @@ -287,6 +287,16 @@ func (k Keeper) SlashRedelegation(ctx context.Context, srcValidator types.Valida | |||
| totalSlashAmount = math.ZeroInt() | |||
| bondedBurnedAmount, notBondedBurnedAmount := math.ZeroInt(), math.ZeroInt() | |||
|
|
|||
| valDstAddr, err := k.validatorAddressCodec.StringToBytes(redelegation.ValidatorDstAddress) | |||
| if err != nil { | |||
| return math.ZeroInt(), fmt.Errorf("SlashRedelegation: could not parse validator destination address: %w", err) | |||
There was a problem hiding this comment.
Thank you for adding context to the errors 🙏🏾
tac0turtle
approved these changes
Oct 10, 2023
tac0turtle
deleted the
x-slashing-hoist-validator+delegator-address-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change hoists out, the parsing of non-changing validator address and delegator address which before were being re-parsed in every loop of the redelegation entries, parsing them once and reusing the already parsed addresses.
Fixes #18032