Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add v0.47.6 changelog to main #18447

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 10, 2023

Description

Add v0.47.6 changelog to main: https://github.com/cosmos/cosmos-sdk/pull/18342/files


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • New Features

    • Introduced standalone mode for gRPC & API servers.
  • Improvements

    • Implemented streaming JSON parser for parsing chain-id from the genesis file.
  • Bug Fixes

    • Ensured block size constraints are respected in proposal preparation.
  • Breaking Changes

    • Removed telemetry for counting votes and proposals, affecting client-side monitoring.

Copy link
Contributor

coderabbitai bot commented Nov 10, 2023

Walkthrough

Walkthrough

The Cosmos SDK has been updated with new features, improvements, and bug fixes. Notably, it now supports running gRPC and API servers independently, enhancing flexibility in deployment scenarios. Performance is improved through a streaming JSON parser for chain-id extraction from the genesis file. The update also addresses a bug ensuring block size constraints are properly enforced during proposal preparation. However, it introduces client-breaking changes by removing telemetry metrics for vote and proposal counts.

Changes

File(s) Summary of Changes
.../server/grpc.go, .../server/api.go Introduced standalone mode for gRPC & API servers.
.../genesis.go Added a streaming JSON parser for parsing chain-id from the genesis file.
.../proposal_handler.go Fixed a bug to ensure block size constraints in PrepareProposal handler.
.../telemetry.go Removed telemetry for counting votes and proposals, leading to client-breaking changes.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@julienrbrt julienrbrt marked this pull request as ready for review November 14, 2023 22:20
@julienrbrt julienrbrt requested a review from a team as a code owner November 14, 2023 22:20
@@ -249,6 +245,8 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Improvements

* [#18204](https://github.com/cosmos/cosmos-sdk/pull/18204) Use streaming json parser to parse chain-id from genesis file.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake in the changelog de-duplication. All good now.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e269c6d and f32c658.
Files selected for processing (1)
  • CHANGELOG.md (5 hunks)
Additional comments: 6
CHANGELOG.md (6)
  • 43-43: The addition of a key_rotation_fee parameter is a significant feature that could impact the economics of key management within the staking module. Ensure that the implications of this change are well-documented and communicated to stakeholders.

  • 53-58: These improvements seem to focus on enhancing the developer experience and performance. The addition of AmountOfNoValidation and the simplification of keyring interfaces are particularly noteworthy as they can reduce the potential for errors and streamline interactions with the SDK.

  • 61-65: The replacement of ctx.VoteInfos with ctx.CometInfo should be carefully checked for compatibility issues across the codebase. Also, the change in crypto | x/auth to include key checks on signatures should be reviewed to ensure it doesn't introduce any security vulnerabilities.

  • 248-248: Using a streaming JSON parser for parsing the chain-id is a significant improvement in terms of performance, especially for large genesis files. This change should be highlighted as it can have a positive impact on node startup times.

  • 546-570: The summary of changes for version 0.47.6 is comprehensive, covering new features, improvements, bug fixes, and client breaking changes. The removal of telemetry for votes and proposals is a breaking change that should be clearly communicated to clients to prepare for alternative solutions.

  • 569-569: The removal of telemetry for votes and proposals is a client breaking change that requires clients to adapt their monitoring setups. It's crucial to provide clear migration paths or alternatives for affected users to transition smoothly.

Comment on lines +559 to +561
* (server) [#18254](https://github.com/cosmos/cosmos-sdk/pull/18254) Don't hardcode gRPC address to localhost.
* (server) [#18251](https://github.com/cosmos/cosmos-sdk/pull/18251) Call `baseapp.Close()` when app started as grpc only.
* (baseapp) [#17769](https://github.com/cosmos/cosmos-sdk/pull/17769) Ensure we respect block size constraints in the `DefaultProposalHandler`'s `PrepareProposal` handler when a nil or no-op mempool is used. We provide a `TxSelector` type to assist in making transaction selection generalized. We also fix a comparison bug in tx selection when `req.maxTxBytes` is reached.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug fix in the DefaultProposalHandler is critical for maintaining the integrity of the consensus process. It's important to ensure that this change has been thoroughly tested, especially since it involves transaction selection and block size constraints.

@julienrbrt julienrbrt added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 4ee4046 Nov 15, 2023
54 of 55 checks passed
@julienrbrt julienrbrt deleted the julien/add-046-and-fix-changelog branch November 15, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants