Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client/v2): support gov proposals (backport #18461) #18473

Closed
wants to merge 10 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 15, 2023

This is an automatic backport of pull request #18461 done by Mergify.
Cherry-pick of 9c3386f has failed:

On branch mergify/bp/release/v0.50.x/pr-18461
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit 9c3386ffd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   client/prompt_validation.go
	modified:   client/v2/README.md
	modified:   client/v2/autocli/flag/builder.go
	modified:   client/v2/internal/flags/flags.go
	new file:   client/v2/internal/prompt/validation.go
	new file:   client/v2/internal/prompt/validation_test.go
	modified:   x/auth/autocli.go
	modified:   x/consensus/autocli.go
	modified:   x/crisis/autocli.go
	modified:   x/distribution/autocli.go
	modified:   x/gov/autocli.go
	modified:   x/gov/client/cli/prompt.go
	modified:   x/gov/client/cli/tx.go
	modified:   x/gov/client/cli/util.go
	modified:   x/mint/autocli.go
	modified:   x/slashing/autocli.go
	modified:   x/staking/autocli.go
	modified:   x/upgrade/autocli.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   client/v2/CHANGELOG.md
	both modified:   client/v2/autocli/msg.go
	both modified:   client/v2/go.mod
	both modified:   client/v2/go.sum
	both modified:   go.mod
	both modified:   go.sum
	both modified:   simapp/go.mod
	both modified:   tests/go.mod
	deleted by us:   tests/starship/tests/go.mod
	deleted by us:   x/accounts/go.mod
	deleted by us:   x/auth/go.mod
	deleted by us:   x/auth/go.sum
	deleted by us:   x/authz/go.mod
	both modified:   x/bank/autocli.go
	deleted by us:   x/bank/go.mod
	deleted by us:   x/bank/go.sum
	both modified:   x/circuit/go.mod
	both modified:   x/circuit/go.sum
	deleted by us:   x/distribution/go.mod
	deleted by us:   x/distribution/go.sum
	both modified:   x/evidence/go.mod
	both modified:   x/evidence/go.sum
	both modified:   x/feegrant/go.mod
	both modified:   x/feegrant/go.sum
	deleted by us:   x/gov/go.mod
	deleted by us:   x/group/go.mod
	deleted by us:   x/group/go.sum
	deleted by us:   x/mint/go.mod
	deleted by us:   x/mint/go.sum
	both modified:   x/nft/go.mod
	both modified:   x/nft/go.sum
	deleted by us:   x/params/go.mod
	deleted by us:   x/params/go.sum
	deleted by us:   x/protocolpool/go.mod
	deleted by us:   x/protocolpool/go.sum
	deleted by us:   x/slashing/go.mod
	deleted by us:   x/slashing/go.sum
	deleted by us:   x/staking/go.mod
	deleted by us:   x/staking/go.sum
	both modified:   x/upgrade/client/cli/tx.go
	both modified:   x/upgrade/go.mod
	both modified:   x/upgrade/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 9c3386f)

# Conflicts:
#	client/v2/CHANGELOG.md
#	client/v2/autocli/msg.go
#	client/v2/go.mod
#	client/v2/go.sum
#	go.mod
#	go.sum
#	simapp/go.mod
#	tests/go.mod
#	tests/starship/tests/go.mod
#	x/accounts/go.mod
#	x/auth/go.mod
#	x/auth/go.sum
#	x/authz/go.mod
#	x/bank/autocli.go
#	x/bank/go.mod
#	x/bank/go.sum
#	x/circuit/go.mod
#	x/circuit/go.sum
#	x/distribution/go.mod
#	x/distribution/go.sum
#	x/evidence/go.mod
#	x/evidence/go.sum
#	x/feegrant/go.mod
#	x/feegrant/go.sum
#	x/gov/go.mod
#	x/group/go.mod
#	x/group/go.sum
#	x/mint/go.mod
#	x/mint/go.sum
#	x/nft/go.mod
#	x/nft/go.sum
#	x/params/go.mod
#	x/params/go.sum
#	x/protocolpool/go.mod
#	x/protocolpool/go.sum
#	x/slashing/go.mod
#	x/slashing/go.sum
#	x/staking/go.mod
#	x/staking/go.sum
#	x/upgrade/client/cli/tx.go
#	x/upgrade/go.mod
#	x/upgrade/go.sum
@mergify mergify bot requested a review from a team as a code owner November 15, 2023 11:31
@mergify mergify bot added the conflicts label Nov 15, 2023
Copy link
Contributor

coderabbitai bot commented Nov 15, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@julienrbrt julienrbrt self-assigned this Nov 15, 2023
@julienrbrt julienrbrt marked this pull request as draft November 15, 2023 11:34
@julienrbrt julienrbrt marked this pull request as ready for review November 15, 2023 11:57
@julienrbrt
Copy link
Member

ref: #18461 (comment)

@julienrbrt julienrbrt added the S:blocked Status: Blocked label Nov 18, 2023
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we close this pr for now?

@julienrbrt
Copy link
Member

can we close this pr for now?

We can, but I can't promise I'll remember to backport this once we fixed api versioning.

@julienrbrt julienrbrt mentioned this pull request Dec 20, 2023
3 tasks
@julienrbrt
Copy link
Member

Tracked here now: #18847

@julienrbrt julienrbrt closed this Dec 20, 2023
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.50.x/pr-18461 branch December 20, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:blocked Status: Blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants