Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gov): consistent logger usage in EndBlocker() #18560

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

taeguk
Copy link
Contributor

@taeguk taeguk commented Nov 27, 2023

Summary by CodeRabbit

  • Refactor
    • Centralized logger retrieval in the EndBlocker function for improved maintainability.
    • Streamlined error logging within the module for consistency.

@taeguk taeguk requested a review from a team as a code owner November 27, 2023 10:06
Copy link
Contributor

coderabbitai bot commented Nov 27, 2023

Walkthrough

Walkthrough

The change involves refactoring the way a logger is accessed in the EndBlocker function of a module. The logger is now obtained through a keeper object rather than directly from the context, aiming to centralize the logging process and enhance code maintainability. The change is internal and does not affect any public interfaces or external behaviors.

Changes

File(s) Change Summary
x/gov/abci.go Refactored to retrieve the logger via the keeper object instead of directly from the context, and updated error logging to use the new logger variable.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@julienrbrt julienrbrt changed the title refactor(gov): consistent logger codes in EndBlocker() refactor(gov): consistent logger usage in EndBlocker() Nov 27, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Nov 27, 2023
Merged via the queue into cosmos:main with commit 02b1b00 Nov 27, 2023
59 of 61 checks passed
@taeguk taeguk deleted the feature/logger branch November 27, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants