feat(x/gov): better gov genesis validation

x/gov/types/v1/genesis.go

@@ -2,6 +2,7 @@ package v1
 
 import (
 	"errors"
+	"fmt"
 
 	"github.com/cosmos/cosmos-sdk/codec/types"
 )
@@ -27,12 +28,63 @@ func (data GenesisState) Empty() bool {
 	return data.StartingProposalId == 0 || data.Params == nil
 }
 
-// ValidateGenesis checks if parameters are within valid ranges
+// ValidateGenesis checks if gov genesis state is valid ranges
+// It checks if params are in valid ranges
+// It also makes sure that the provided proposal IDs are unique and
+// that there are no duplicate deposit or vote records and no vote or deposits for non-existent proposals
 func ValidateGenesis(data *GenesisState) error {
 	if data.StartingProposalId == 0 {
 		return errors.New("starting proposal id must be greater than 0")
 	}
 
+	// verify proposal IDs
+	proposalIds := make(map[uint64]struct{})
+	for _, p := range data.Proposals {
+		if _, ok := proposalIds[p.Id]; ok {
+			return fmt.Errorf("duplicate proposal id: %d", p.Id)
+		}
+
+		proposalIds[p.Id] = struct{}{}
+	}
+
+	// verify deposits
+	type depositKey struct {
+		ProposalId uint64
+		Depositor  string
+	}
+	depositIds := make(map[depositKey]struct{})
+	for _, d := range data.Deposits {
+		if _, ok := proposalIds[d.ProposalId]; !ok {
+			return fmt.Errorf("deposit %v has non-existent proposal id: %d", d, d.ProposalId)
+		}
+
+		dk := depositKey{d.ProposalId, d.Depositor}
+		if _, ok := depositIds[dk]; ok {
+			return fmt.Errorf("duplicate deposit: %v", d)
+		}
+
+		depositIds[dk] = struct{}{}
+	}
+
+	// verify votes
+	type voteKey struct {
+		ProposalId uint64
+		Voter      string
+	}
+	voteIds := make(map[voteKey]struct{})
+	for _, v := range data.Votes {
+		if _, ok := proposalIds[v.ProposalId]; !ok {
+			return fmt.Errorf("vote %v has non-existent proposal id: %d", v, v.ProposalId)
+		}
+
+		vk := voteKey{v.ProposalId, v.Voter}
+		if _, ok := voteIds[vk]; ok {
+			return fmt.Errorf("duplicate vote: %v", v)
+		}
+
+		voteIds[vk] = struct{}{}
+	}
+
 	return data.Params.ValidateBasic()
 }
 

x/gov/types/v1/genesis_test.go

@@ -93,6 +93,83 @@ func TestValidateGenesis(t *testing.T) {
 			},
 			expErr: true,
 		},
+		{
+			name: "duplicate proposals",
+			genesisState: func() *v1.GenesisState {
+				state := v1.NewGenesisState(v1.DefaultStartingProposalID, params)
+				state.Proposals = append(state.Proposals, &v1.Proposal{Id: 1})
+				state.Proposals = append(state.Proposals, &v1.Proposal{Id: 1})
+
+				return state
+			},
+			expErr: true,
+		},
+		{
+			name: "duplicate votes",
+			genesisState: func() *v1.GenesisState {
+				state := v1.NewGenesisState(v1.DefaultStartingProposalID, params)
+				state.Proposals = append(state.Proposals, &v1.Proposal{Id: 1})
+				state.Votes = append(state.Votes,
+					&v1.Vote{
+						ProposalId: 1,
+						Voter:      "voter",
+					},
+					&v1.Vote{
+						ProposalId: 1,
+						Voter:      "voter",
+					})
+
+				return state
+			},
+			expErr: true,
+		},
+		{
+			name: "duplicate deposits",
+			genesisState: func() *v1.GenesisState {
+				state := v1.NewGenesisState(v1.DefaultStartingProposalID, params)
+				state.Proposals = append(state.Proposals, &v1.Proposal{Id: 1})
+				state.Deposits = append(state.Deposits,
+					&v1.Deposit{
+						ProposalId: 1,
+						Depositor:  "depositor",
+					},
+					&v1.Deposit{
+						ProposalId: 1,
+						Depositor:  "depositor",
+					})
+
+				return state
+			},
+			expErr: true,
+		},
+		{
+			name: "non-existent proposal id in votes",
+			genesisState: func() *v1.GenesisState {
+				state := v1.NewGenesisState(v1.DefaultStartingProposalID, params)
+				state.Votes = append(state.Votes,
+					&v1.Vote{
+						ProposalId: 1,
+						Voter:      "voter",
+					})
+
+				return state
+			},
+			expErr: true,
+		},
+		{
+			name: "non-existent proposal id in deposits",
+			genesisState: func() *v1.GenesisState {
+				state := v1.NewGenesisState(v1.DefaultStartingProposalID, params)
+				state.Deposits = append(state.Deposits,
+					&v1.Deposit{
+						ProposalId: 1,
+						Depositor:  "depositor",
+					})
+
+				return state
+			},
+			expErr: true,
+		},
 	}
 
 	for _, tc := range testCases {