Rename transient store key to be a unique key. #2013
Conversation
This caused an error with non-determinism between nodes with same gaiad version and genesis.
Codecov Report
@@ Coverage Diff @@
## release/v0.24.0 #2013 +/- ##
================================================
Coverage 64.86% 64.86%
================================================
Files 115 115
Lines 6862 6862
================================================
Hits 4451 4451
Misses 2127 2127
Partials 284 284 |
|
This looks fine, but can we add a testcase which fails before and passes now? I think this is a result of |
|
I think we should run I think we also need a conditional to panic on duplicate store key in the SDK. I can work on a testcase for this though. |
|
Upon further thought, I don't think writing a testcase is a good utilization of time. We'd be relying on the functionality of registering duplicate keys being allowed, but if we want to remove that as a possibility it would likely be simpler to just write that fix. |
There was a problem hiding this comment.
Overall, I agree @ValarDragon. In can't hurt to add both (remove functionality and add test). But for now, I think this will suffice.
PENDING.md
Outdated
| @@ -7,7 +7,8 @@ BREAKING CHANGES | |||
| * Gaia CLI (`gaiacli`) | |||
|
|
|||
| * Gaia | |||
|
|
|||
| * Make the transient store key use a distinct store key. | |||
There was a problem hiding this comment.
Can we mark/tag the PR (#2013) here?
| @@ -78,7 +78,7 @@ func NewGaiaApp(logger log.Logger, db dbm.DB, traceStore io.Writer, baseAppOptio | |||
| keyGov: sdk.NewKVStoreKey("gov"), | |||
| keyFeeCollection: sdk.NewKVStoreKey("fee"), | |||
| keyParams: sdk.NewKVStoreKey("params"), | |||
| tkeyParams: sdk.NewTransientStoreKey("params"), | |||
| tkeyParams: sdk.NewTransientStoreKey("transient_params"), | |||
This caused an error with non-determinism between nodes with same
gaiad version and genesis. Fixes the issue (we think) for what we saw in internal testnets.
For Admin Use: