dep: Fix error with scratch directory

[ValarDragon]

If dep already sees its scratch directory (.vendor-new), dep ensure fails. This rm -rf's that directory so that make get_vendor_deps doesn't fail.

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #2016 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2016   +/-   ##
========================================
  Coverage    64.86%   64.86%           
========================================
  Files          115      115           
  Lines         6862     6862           
========================================
  Hits          4451     4451           
  Misses        2127     2127           
  Partials       284      284

[alexanderbez]

LGTM. Did we ever have a clean target that removed the entire vendor directory?

[ValarDragon]

We used to nuke the vendor directory. I had removed that since we started enforcing no branches being allowed in the toml. (Enforced in linting) This avoided us getting weird things with the vendor directory being out of sync. I don't think there is actually need to rm -rf the vendor directory anymore, it seems like dep handles it. This has the added advantage that you don't have to update all dependencies every time, dep more intelligently only updates the ones which had a diff in the lock.

I think a clean command would be cool, for deleting all of ~/.gaiad, ~/.gaiacli, vendor, mylocalnet, build, for use only within development environments.

[cwgoes]

utACK, agreed on introducing make clean