Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R staking lcd bugfix #2033

Merged
merged 1 commit into from
Aug 15, 2018
Merged

R4R staking lcd bugfix #2033

merged 1 commit into from
Aug 15, 2018

Conversation

rigelrozanski
Copy link
Contributor

Use the owner address instead of pubkey address in queries,
Also no more iteration to find a validator, see this issue for more:

Closes #2032

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • NEED MORE lcd docs! - Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, although maybe this could use the "CLI keeper" PR @sunnya97 is working on to be a bit cleaner

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK -- Thanks @rigelrozanski

@cwgoes cwgoes merged commit 5fff217 into develop Aug 15, 2018
@cwgoes cwgoes deleted the rigel/lcd-staking-fix branch August 15, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants