-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types/collections): add LegacyDec
collection value
#21693
Conversation
Co-authored-by: Luca Graziotti <luca@noble.xyz>
WalkthroughWalkthroughThe changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant LegacyDecValueCodec
participant MathLegacyDec
Client->>LegacyDecValueCodec: Encode(math.LegacyDec)
LegacyDecValueCodec->>MathLegacyDec: Convert to byte representation
MathLegacyDec-->>LegacyDecValueCodec: Byte data
LegacyDecValueCodec-->>Client: Encoded byte data
Client->>LegacyDecValueCodec: Decode(byte data)
LegacyDecValueCodec->>MathLegacyDec: Convert byte data to math.LegacyDec
MathLegacyDec-->>LegacyDecValueCodec: LegacyDec instance
LegacyDecValueCodec-->>Client: Decoded math.LegacyDec instance
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
LegacyDec
collection valueLegacyDec
collection value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@johnletey can you lint and merge main then we can merge it |
@tac0turtle The linter doesn't seem to be related to this PR, should I still fix it? |
It should be fixed on main already |
@julienrbrt Looks like the |
Shouldn't be but looks like it.. |
Co-authored-by: Luca Graziotti <luca@noble.xyz> (cherry picked from commit 3bc707a)
Co-authored-by: Luca Graziotti <luca@noble.xyz> (cherry picked from commit 3bc707a) # Conflicts: # types/collections.go
* main: test: fix sims (#21735) build: bump proto-builder (#21730) refactor(schema)!: rename IntegerStringKind and DecimalStringKind (#21694) feat(types/collections): add `LegacyDec` collection value (#21693) refactor(server): alias AppOptions to coreserver.DynamicConfig (#21711) refactor(simapp): simplify simapp di (#21718) feat: replace the cosmos-db usecases in the tests with `core/testing` (#21525) feat(runtime/v2): store loader on simappv2 (#21704) docs(x/auth): vesting (#21715) build(deps): Bump google.golang.org/grpc from 1.66.1 to 1.66.2 (#21670) refactor(systemtest): Add cli.RunAndWait for common operations (#21689) fix(runtime/v2): provide default factory options if unset in app builder (#21690) chore: remove duplicate proto files for the same proto file (#21648) feat(x/genutil): add better error messages for genesis validation (#21701) build(deps): Bump cosmossdk.io/core from 1.0.0-alpha.1 to 1.0.0-alpha.2 (#21698) test: migrate e2e/bank to system tests (#21607) chore: fix the gci lint issue in testutil (#21695) docs(x/authz): update grant docs (#21677)
…osmos#21693) (cosmos#21724) (#6) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit