WIP: use block power throughout distribution (II) #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaekwon
force-pushed
the
jae/check-supply-in-simulation
branch
from
60ca663
to
47faf63
Compare
jaekwon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
jaekwon
force-pushed
the
jae/check-supply-in-simulation
branch
from
47faf63
to
1164c9e
Compare
jaekwon
force-pushed
the
jae/check-supply-in-simulation
branch
from
1164c9e
to
1cc7432
Compare
|
Can we close #2541 then? |
| GetValidator() ValAddress // validator operator address | ||
| GetShares() Dec // amount of validator's shares held in this delegation | ||
| GetDelegatorAddr() AccAddress // delegator AccAddress for the bond | ||
| GetValidatorAddr() ValAddress // validator operator address |
There was a problem hiding this comment.
We should keep renaming as a separate PR - muddies being able to view the core changes
There was a problem hiding this comment.
even though ++ on the change here - leave for now
5 tasks
…n' into jae/check-supply-in-simulation
mistake
Codecov Report
@@ Coverage Diff @@
## cwgoes/check-supply-in-simulation #2552 +/- ##
=====================================================================
+ Coverage 59.84% 59.89% +0.04%
=====================================================================
Files 150 150
Lines 8632 8692 +60
=====================================================================
+ Hits 5166 5206 +40
- Misses 3112 3130 +18
- Partials 354 356 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2541.