Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: make gaiacli config handle "indent" flag #3342

Merged
merged 2 commits into from
Jan 22, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 22, 2019

It defaults to false, users can override it via gaiacli config
and avoid to append --indent to all commands:

$ gaiacli config indent true

Closes: #2607

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

It defaults to false, users can override it via gaiacli config
and avoid to append --indent to all commands:

    $ gaiacli config indent true

Closes: #2607
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition! Thanks @alessio

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #3342 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #3342      +/-   ##
==========================================
+ Coverage     55.6%   55.6%   +<.01%     
==========================================
  Files          132     132              
  Lines         9559    9556       -3     
==========================================
- Hits          5315    5314       -1     
+ Misses        3907    3905       -2     
  Partials       337     337

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit b055c12 into develop Jan 22, 2019
@cwgoes cwgoes deleted the alessio/2607-add-indent-to-gaiacli-config branch January 22, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants